Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix passing secrets to runtime_prereleases #30504

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2024

Stack from ghstack (oldest at bottom):

Second try, seems like you need to explicitly pass secrets to reusable
workflows.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 6:20pm

poteto added a commit that referenced this pull request Jul 29, 2024
Second try, seems like you need to explicitly pass secrets to reusable
workflows.

ghstack-source-id: 05ffdae13474dba64119182bf72c15d07f83efd2
Pull Request resolved: #30504
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 29, 2024
@react-sizebot
Copy link

Comparing: 9938e24...fc0dd90

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.28 kB 506.28 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 601.27 kB 601.27 kB = 106.28 kB 106.28 kB
facebook-www/ReactDOM-prod.modern.js = 577.38 kB 577.38 kB = 102.52 kB 102.52 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f59bd5f

@poteto poteto merged commit f59bd5f into gh/poteto/1/base Jul 29, 2024
188 checks passed
poteto added a commit that referenced this pull request Jul 29, 2024
Second try, seems like you need to explicitly pass secrets to reusable
workflows.

ghstack-source-id: 05ffdae13474dba64119182bf72c15d07f83efd2
Pull Request resolved: #30504
@poteto poteto deleted the gh/poteto/1/head branch July 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants